commit 6f00a861b476e9b13c91ab5a65442cbae89990c9
Author: Obsidian <obsid@free.fr>
Date: Sat Dec 23 03:27:14 2017 +0100
Missing wrapping tags on "users-comments" page.
Missing "nav.toolbox" and "div#comments" around appropriate
sections, and class "thread" to ul list on user page when choosing
"Accès aux derniers : . commentaires".
Even though it surely looks like a bug, this is not quite visible
with default CSS but Steelblue definitely needs them. These additions
cause no regression with standard CSS.
----
Please note that the %style block is here to make page selectors reappear:
They're hidden on purpose by RonRonnement to mask the one at top of the
page (line 932), and next selector is supposed to spot the last one to
make it reappear. Unfortunately, it doesn't work on this particular page,
but nobody ever noticed especially because those malformed tags were
never matched by the CSS.
We simply need to correct this in the default CSS (one row to add just after
the line quoted above) but this will be the point of another further patch
to come. This particular revision is there to show that everything's still
working fine without starting to modify the default CSS.
commit 37f0685a65e741683f9833ae5ec0d0babbb0326d
Author: Obsidian <obsid@free.fr>
Date: Thu Dec 21 20:56:02 2017 +0100
Add odd/even parity classes on last table of user statistics
This last table is very hard to discriminate through CSS selectors,
because it has no specific classes set on the rows themselves, and
because each slice don't have a fixed number of rows neither.
Something much better would have been to wrap each slice inside its
own tbody block, but breaking the table cell lineage was prone to
induce regressions on other CSS.
If needed and appreciated, we'll do that as a specific task when this
submission is considered stable.
commit 338b8cb90e857198598b24dbe29d1fbf4760b846
Author: Obsidian <obsid@free.fr>
Date: Wed Dec 20 16:23:24 2017 +0100
Replacing inline style "width: 100px" on statistics table cells by a specific class
These clauses are the second inline styles we want to get rid of (with the
main logo image stuff treated at first of the pull request).
They seem to always accompany similar statement where width is declared dynamically
to implement progress bars. While this particular behavour is justified, fixing
size of adjacent cells to 100px seems to be here only to prevent them from shrinking.
Also, there's no cells elsewhere set to another fixed width. Every similar statement
seems to be here to fit icon images.
As before, we point these cells out with a specific class instead, which style is
defined in page header before CSS links. The point of this is to avoid resorting to
use "!important", while still inducing no regressions in all existing CSS.
TODO: _head.html.haml could be improved to include this
statement only in statistics pages.
commit 954ad3febdc35fc8b0630ebaf538eb96327a024e
Author: Obsidian <obsid@free.fr>
Date: Mon Dec 18 00:26:46 2017 +0100
Adding a class ".container" to section#container and section#redaction
This basically affects almost all the pages of the server, but induces
no regression, since neither of these tags had classes so far.
We mainly need this because there's one page that is not contained inside
a section#container tag: the news redaction page (that is, the most important
one), but it stills contains the articles that will be published.
Since there's over 200 differents statements affecting articles and other
"contained" contents, and considering the facts that each of these statements
are very often multiplied to match pseudo classes and such, and some of them
are either exceptions or context-specific stuff (e.g. #phare vs. #main), they
can't be easily wrapped inside scss brackets { } (which should be avoided
anyway when there's too much clauses over them. We have the problem elsewhere
with public pages supposed to have a dark background).
Another "bad" solution would consist of duplicating all of them in another
specific section decicated to #redaction. We don't want that neither.
The best solution remains the addition of a specific class that can easily
apply to any other "oddity" such as this one. This hack moreover is a very
small and simple one, and can be reverted without any difficulty.
commit 623f74e735d5540fb5bb0ad5f26d1999623b7f32
Author: Obsidian <obsid@free.fr>
Date: Mon Dec 18 00:10:44 2017 +0100
Improvements to redaction page: punctuation & class "activity"
. Missing "?" mark, narrow non-breakable spaces added before each
of them.
. Added a class "activity" to each "news" box to improve page layouts
and CSS enhancements. We currently only have the "chat" icon to spot
them all.
commit 0df1b36cef38a3594b3827fbf81e5f9448cb12c0
Author: Obsidian <obsid@free.fr>
Date: Sat Dec 16 15:22:35 2017 +0100
Add descriptive tags and classes to user-specific moderation log
This patch adds a class named "history" to <h2> "Historique" and following <ul>
list, then breaks down the content of each list item into <span.date>, <span.sep>
(separators), <span.name> and <span.decription>.
Also add additionnal classes "block" and "plonk" to corresponding divisions
following the dropdown-like buttons (which are already marked this way).
commit 200c1b3d0b88514cd5b67d8e5412807c2153849a
Author: Obsidian <obsid@free.fr>
Date: Fri Dec 15 22:10:24 2017 +0100
Bug fix on new forum entry page : some tags where outside their container
Tags <article>, <form#new_post> and <dev.markdown_cheatse> where outside
the <main#contents> container as it was supposed to be, and as it is on
other similar pages (for instance, posting a new diary).
This was due to a lack of a proper indentation. This patch fixes this.
As usual, no regression induced with the main CSS.
commit 05d10892a4ca68820179b5c51cf6816a63289134
Author: Obsidian <obsid@free.fr>
Date: Thu Dec 14 02:11:20 2017 +0100
Adding "div.sideforms" around page bottom forms on stylesheet selection page.
Addition of a division named "div.sideforms" to allow URL box and file
selector to properly fit on the right of the CSS snapshot gallery.
The gallery is designed to occupy either 60% of the main container OR a
maximum width limit of 520 pixels (image native dimension 400×400 plus some
margins), whichever is the smalest, leaving the rest to text and notices.
The gallery is implemented as a left floating box, which can be wrapped only
by the main stream, that is plain text or at least an inline box (inline-block
or inline-flex).
We thus need an invisible wrapper so we can treat the content as regular boxes,
to draw a frame and do some item alignments inside. This can't be done with CSS
selectors only. Note that declaring <form> tags as inline blocks do work, but
they would no longer expand to fit the whole of the remaining width on the right.
commit 50bf027780d0fa1ae11508f2407616be8dd5761b
Author: Obsidian <obsid@free.fr>
Date: Fri Dec 8 17:32:27 2017 +0100
Add div#comments when composing a new comment
Wrap the comment section (including the one we reply to)
inside a div#comments on the composing page.
This applies to both a reply to an article (news/diary/forum entry)
or another comment, which are two distinct cases.
CSS such as Steelblue distinguish these two cases but don't rely on the
code to do so. However, they still need a well-placed div#comments box.
commit b37f55a022d7ce15c28ba96ee4142cafadd14590
Author: Obsidian <obsid@free.fr>
Date: Thu Dec 7 22:43:20 2017 +0100
Adding a class vote-for or vote-against on comment's "li" element
Mark a whole comment as upvoted or downvoted through a class on the
comment's root element (which is a list item inside the whole comment
tree).
This can be used to enlight the whole box or to decorate a single element
inside through CSS selector, but it also can be used to easily implement
additional features such as automaticaly hiding disapproved comments
regardless of their score. These feature may be written in a global scope
inside the server code, proposed to users as Javascript extensions, or
offered as third-party components through GreaseMonkey scripts or such.
Implemented for CSS "Steelblue" as part of pull-request commits.
commit e900da18ed46986663b239ece55248ac68addb90
Author: Obsidian <obsid@free.fr>
Date: Thu Dec 7 14:48:40 2017 +0100
Adding specific classes to dashboard link when there's new answers or not.
CSS requirements again. Ok, we could have used CSS sibling selectors to
target the link itself, but since we already have submitted a bunch of
other patches, this is still much better, isn't it ? Now we can focus on
the complete list item if needed.
commit 8d8121307ddeaed63ff14c12f34bff8199cc6dd7
Author: Obsidian <obsid@free.fr>
Date: Thu Dec 7 01:47:04 2017 +0100
Adding missing div#comments tag on single comment viewing pages
When showing a particular comment outside of this thread page
by clicking on its title, the generated page misses the div#comments
tag supposed to embed the comment's HTML structure, thus causing
some CSS to fail.
Fixed here.
Concerned pages match http<s>://linuxfr.org/nodes/<xxx>/comments/<yyy>
commit 900bc7d56a93c04b8fababcfc548ccb1b647d21c
Author: Obsidian <obsid@free.fr>
Date: Wed Dec 6 03:36:38 2017 +0100
Adding a title on link "Follow comment stream"
Add the content of <a> tag as a title so it can be displayed
when hovering it. It's useful for CSS that display that link
as a simple RSS/Atom icon (Steelblue does).
commit d8a9774a22be3ccb1f5a11a7c9fe3a2792756bd1
Author: Obsidian <obsid@free.fr>
Date: Tue Dec 5 16:33:06 2017 +0100
"Aller" -> "Remonter" - ("au commentaire parent")
Changing "go to parent comment"
for "reach back parent comment"
commit 5bacd00e56ab5c81005a0a4c55d7fc3269e706cc
Author: Obsidian <obsid@free.fr>
Date: Sat Dec 2 20:59:39 2017 +0100
Add a link on poll box header title toward global poll section
This box missed a link on its main h1 title, although it was
totally relevant in this context (not every box has a link but
similar ones do have one).
This patch introduces it.